On Tue, Jan 13, 2015 at 03:16:10PM +0000, Qais Yousef wrote: > On 01/13/2015 02:59 PM, Vinod Koul wrote:
> >>being NULL, hence when trying to set rtd a few lines below we get an oops. > >It is a good practice to add the oops here > Will this really be helpful? I think it'll be more clutter (the backtrace on > metag arch is not great): It's better in general to leave it out unless it's adding something (for example sometimes the particular call path is important) and even there edit it down to relevant details - the splat from the full oops normally overwhelms the commit message.
signature.asc
Description: Digital signature
