Re: [PATCH] rtlwifi/rtl8192de: remove redundant else if check

[Larry Finger]

On 01/13/2015 08:07 AM, Colin King wrote:

From: Colin Ian King <colin.k...@canonical.com>

The else if check condition checks for the opposite of the
if check, hence the else if check is redundant and can be
replaced with a simple else:

if (rtlpriv->rtlhal.macphymode == SINGLEMAC_SINGLEPHY) {
        ..
} else if (rtlpriv->rtlhal.macphymode != SINGLEMAC_SINGLEPHY) {
        ..
}

replaced with:

if (rtlpriv->rtlhal.macphymode == SINGLEMAC_SINGLEPHY) {
        ..
} else {
        ..
}

Signed-off-by: Colin Ian King <colin.k...@canonical.com>

Acked-by: Larry Finger <larry.fin...@lwfinger.net>

Thanks,

Larry

---
  drivers/net/wireless/rtlwifi/rtl8192de/hw.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/wireless/rtlwifi/rtl8192de/hw.c 
b/drivers/net/wireless/rtlwifi/rtl8192de/hw.c
index 280c3da..01bcc2d 100644
--- a/drivers/net/wireless/rtlwifi/rtl8192de/hw.c
+++ b/drivers/net/wireless/rtlwifi/rtl8192de/hw.c
@@ -546,7 +546,7 @@ static bool _rtl92de_llt_table_init(struct ieee80211_hw *hw)
                txpktbuf_bndy = 246;
                value8 = 0;
                value32 = 0x80bf0d29;
-       } else if (rtlpriv->rtlhal.macphymode != SINGLEMAC_SINGLEPHY) {
+       } else {
                maxPage = 127;
                txpktbuf_bndy = 123;
                value8 = 0;

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/