On Tue, Jan 13, 2015 at 04:59:03PM +0000, Victor Kamensky wrote: > Aarch64 ELF files use mapping symbols with special names $x, $d > to identify regions of Aarch64 code (see Aarch64 ELF ABI - "ARM > IHI 0056B", section "4.5.4 Mapping symbols"). > > The patch filters out these symbols at load time, similar to > "696b97a perf symbols: Ignore mapping symbols on ARM" changes > done for ARM before V8. > > Signed-off-by: Victor Kamensky <[email protected]> > Cc: Peter Zijlstra <[email protected]> > Cc: Paul Mackerras <[email protected]> > Cc: Ingo Molnar <[email protected]> > Cc: Arnaldo Carvalho de Melo <[email protected]> > Cc: Adrian Hunter <[email protected]> > Cc: Jiri Olsa <[email protected]> > Cc: Namhyung Kim <[email protected]> > Cc: Avi Kivity <[email protected]> > Cc: Masami Hiramatsu <[email protected]> > Cc: Anton Blanchard <[email protected]> > Cc: David Ahern <[email protected]> > Cc: Will Deacon <[email protected]> > Cc: Dave Martin <[email protected]> > --- > tools/perf/util/symbol-elf.c | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/tools/perf/util/symbol-elf.c b/tools/perf/util/symbol-elf.c > index 06fcd1b..1e188dd 100644 > --- a/tools/perf/util/symbol-elf.c > +++ b/tools/perf/util/symbol-elf.c > @@ -862,6 +862,14 @@ int dso__load_sym(struct dso *dso, struct map *map, > !strcmp(elf_name, "$t")) > continue; > } > + /* Reject Aarch64 ELF "mapping symbols": these aren't unique and > + * don't identify functions, so will confuse the profile > + * output: */ > + if (ehdr.e_machine == EM_AARCH64) { > + if (!strcmp(elf_name, "$x") || > + !strcmp(elf_name, "$d")) > + continue; > + }
Do we need to skip $x.* and $d.* too? I doubt GCC generates them, but they are permitted by the ELF ABI. Will -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
