Hello Peter, sorry about that! But thank you very much for the advice. This is my first patch on Linux Kernel, so each word will help me a lot.
Thanks, Bruno On Sun, Jan 18, 2015 at 02:33:23PM +0100, Peter Hüwe wrote: > Hi Bruno, > > thanks for your patch! > The patch is fine, > but unfortunately not against the latest version of the tpm subsytem code. > > You can find the latest version of the tpm subsystem at > https://github.com/PeterHuewe/linux-tpmdd > the for-james branch is usually the best choice here. > > Nevertheless, I quickly ported it to the latest code (see below) > --> applied. > > > > > Fixed some coding style issues. > Usually it is quite good if you include the reports by checkpatch. > > Thanks, > Peter > > > So this is what got merged, the rest does not apply anymore due to recent > code > changes: > > > > From: Bruno E O Meneguele <bmenegu...@gmail.com> > Date: Sat, 17 Jan 2015 17:03:30 +0100 > Subject: [PATCH] char/tpm: fixed white spaces coding style issues > > Fixed some coding style issues reported by checkpatch. > > Signed-off-by: Bruno E O Meneguele <bmenegu...@gmail.com> > [phuewe: ported to latest code] > Signed-off-by: Peter Huewe <peterhu...@gmx.de> > --- > drivers/char/tpm/tpm.h | 6 +++--- > drivers/char/tpm/tpm_i2c_stm_st33.c | 2 +- > 2 files changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/char/tpm/tpm.h b/drivers/char/tpm/tpm.h > index cc421cf..7b0727c 100644 > --- a/drivers/char/tpm/tpm.h > +++ b/drivers/char/tpm/tpm.h > @@ -10,13 +10,13 @@ > * Maintained by: <tpmdd-de...@lists.sourceforge.net> > * > * Device driver for TCG/TCPA TPM (trusted platform module). > - * Specifications at www.trustedcomputinggroup.org > + * Specifications at www.trustedcomputinggroup.org > * > * This program is free software; you can redistribute it and/or > * modify it under the terms of the GNU General Public License as > * published by the Free Software Foundation, version 2 of the > * License. > - * > + * > */ > #include <linux/module.h> > #include <linux/delay.h> > @@ -141,7 +141,7 @@ struct tpm_vendor_specific { > u16 manufacturer_id; > }; > > -#define TPM_VPRIV(c) (c)->vendor.priv > +#define TPM_VPRIV(c) ((c)->vendor.priv) > > #define TPM_VID_INTEL 0x8086 > #define TPM_VID_WINBOND 0x1050 > diff --git a/drivers/char/tpm/tpm_i2c_stm_st33.c > b/drivers/char/tpm/tpm_i2c_stm_st33.c > index dbab8d0..612845b 100644 > --- a/drivers/char/tpm/tpm_i2c_stm_st33.c > +++ b/drivers/char/tpm/tpm_i2c_stm_st33.c > @@ -777,7 +777,7 @@ tpm_stm_i2c_probe(struct i2c_client *client, const struct > i2c_device_id *id) > IRQF_TRIGGER_HIGH, > "TPM SERIRQ management", chip); > if (ret < 0) { > - dev_err(chip->pdev , "TPM SERIRQ signals %d not > available\n", > + dev_err(chip->pdev, "TPM SERIRQ signals %d not > available\n", > client->irq); > goto _tpm_clean_answer; > } > -- > 2.0.5 > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
