Le 26/01/2015 11:36, Sylvain Rochet a écrit : > Hello Wenyou, > > On Mon, Jan 26, 2015 at 05:38:59PM +0800, Wenyou Yang wrote: >> From: Peter Rosin <p...@axentia.se> >> >> The DDRSDR controller fails miserably to put LPDDR1 memories in >> self-refresh. Force the controller to think it has DDR2 memories >> during the self-refresh period, as the DDR2 self-refresh spec is >> equivalent to LPDDR1, and is correctly implemented in the >> controller. >> >> Assume that the second controller has the same fault, but that is >> untested. >> >> Signed-off-by: Peter Rosin <p...@axentia.se> >> Acked-by: Nicolas Ferre <nicolas.fe...@atmel.com> >> --- >> arch/arm/mach-at91/pm_slowclock.S | 43 >> +++++++++++++++++++++++++++++++----- >> include/soc/at91/at91sam9_ddrsdr.h | 2 +- >> 2 files changed, 39 insertions(+), 6 deletions(-) >> >> diff --git a/arch/arm/mach-at91/pm_slowclock.S >> b/arch/arm/mach-at91/pm_slowclock.S >> index e2bfaf5..1155217 100644 >> --- a/arch/arm/mach-at91/pm_slowclock.S >> +++ b/arch/arm/mach-at91/pm_slowclock.S >> @@ -100,6 +100,16 @@ ddr_sr_enable: >> cmp memctrl, #AT91_MEMCTRL_DDRSDR >> bne sdr_sr_enable >> >> + /* LPDDR1 --> force DDR2 mode during self-refresh */ > > I think we should explain we are dealing with an errata here, this is > not obvious at first sight, the patch summary may find its place here :-)
True but the problem is that this errata is not public yet, it will be in a couple of weeks. I have the feeling though that the commit message is pretty clear. We'll maybe add that it"s an actual errata. Bye, -- Nicolas Ferre -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
