On Fri, Jul 08, 2005 at 02:54:07PM -0500, [EMAIL PROTECTED] wrote: > > Also, why not just add the hotplug flag to the firmware structure? > That > request_firmware kmalloc's the firmware structure and frees it when > returned. The only way to indicate request_firmware to skip hotplug was > by passing a hotplug flag on the stack.
Ok, how about changing the function to pass in a flag saying what it wants (wait/nowait, hotplug/nohotplug) and fix up all callers of it? > > way you don't have to add another function just to add another flag. > > And you could probably get rid of the nowait version in the same way. > Also thought of leaving request_firmware_nowait intact didn't want to > break others using this function. Did you find any other in-kernel use of request_firmware_nowait? I don't see any :) thanks, greg k-h - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/