Arnd Bergmann <[email protected]> writes: > On Wednesday 28 January 2015 22:42:28 David Miller wrote: >> From: Behan Webster <[email protected]> >> Date: Wed, 28 Jan 2015 17:36:14 -0800 >> >> > Missing MODULE_DEVICE_TABLE for pci ids from benet driver found by clang. >> > >> > Signed-off-by: Behan Webster <[email protected]> >> > Suggested-by: Arnd Bergmann <[email protected]> >> >> Why are you removing the device table? > > Behan took a patch that I did earlier and split it up to add descriptions. > The patch is correct, but he either misunderstood or misexpressed the > intention. > > This driver has two identical lines that both say > > MODULE_DEVICE_TABLE(pci, be_dev_ids); > > I don't remember the exact symptom, but llvm/clang trips over this, while gcc > silently ignores the second one.
GCC is probably being "helpful" and allowing multiple identical definitions even though the C spec does not. Obviously all but one should go away. No need to mention llvm, IMO. -- Måns Rullgård [email protected] -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
