On Sun, 10 Jul 2005 21:21:42 +0300 Pekka Enberg wrote: | Hi Roman, | | At some point in time, I wrote: | > > Roman, it is not as if I get to decide for the patch submitters. I | > > comment on any issues _I_ have with the patch and the authors fix | > > whatever they want (or what the maintainers ask for). | | On Fri, 2005-07-08 at 21:59 +0200, Roman Zippel wrote: | > The point of a review is to comment on things that _need_ fixing. Less | > experienced hackers take this a requirement for their drivers to be | > included. | | Hmm. So we disagree on that issue as well. I think the point of review | is to improve code and help others conform with the existing coding | style which is why I find it strange that you're suggesting me to limit | my comments to a subset you agree with. | | Would you please be so kind to define your criteria for things that | "need fixing" so we could see if can reach some sort of an agreement on | this. My list is roughly as follows: | | - Erroneous use of kernel API | - Bad coding style | - Layering violations | - Duplicate code | - Hard to read code
Those are all good points IMO, but there is little (or no) concensus on "bad coding style" or "hard to read code". Maybe it would make more sense to make some suggested changes to Documentation/CodingStyle (in the form of a patch) and see what kinds of reactions (support) it gets. --- ~Randy - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
