> > > > drivers/infiniband/core/mad.c:2088:3-8: WARNING: NULL check before > > freeing functions like kfree, debugfs_remove, debugfs_remove_recursive > > or usb_free_urb is not needed. Maybe consider reorganizing relevant > > code to avoid passing NULL values. > > > > NULL check before some freeing functions is not needed. > > > > Based on checkpatch warning > > "kfree(NULL) is safe this check is probably not required" > > and kfreeaddr.cocci by Julia Lawall. > > > > Generated by: scripts/coccinelle/free/ifnullfree.cocci > > > > Signed-off-by: Fengguang Wu <[email protected]> > > > Signed-off-by: Ira Weiny <[email protected]>
Sorry this should have been: Reviewed-by: Ira Weiny <[email protected]> Tested-by: Ira Weiny <[email protected]> > > > > --- > > > > mad.c | 3 +-- > > 1 file changed, 1 insertion(+), 2 deletions(-) > > > > --- a/drivers/infiniband/core/mad.c > > +++ b/drivers/infiniband/core/mad.c > > @@ -2084,8 +2084,7 @@ out: > > /* Post another receive request for this QP */ > > if (response) { > > ib_mad_post_receive_mads(qp_info, response); > > - if (recv) > > - kfree(recv); > > + kfree(recv); > > } else > > ib_mad_post_receive_mads(qp_info, recv); } > -- > To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the > body > of a message to [email protected] More majordomo info at > http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
