On 02/05/2015 11:44 AM, Aaron Wu wrote: > Rewrite the blackfin CAN driver into more common style in three ways: > part 1/3: rewrite blackfin style of read/write into common readw/writew > part 2/3: introduce ioremap to be compitable with MMU enabled arch > part 3/3: merge the header file from the blackfin arch dependent > location to driver code directly, note the original copy of more completed > bfin_can.h in arch depentdent location is reserved for reg test purpose > > V5 changes: merge contents of header file into drivere code in patch 3/3 > V4 changes: remove unused variable in patch 2/3 > V3 changes: remove redundant cast in patch 2/3 > V2 changes: split patch into two parts > V1 changes: rewrite code into common style > > Signed-off-by: Aaron Wu <aaron...@analog.com> > --- > drivers/net/can/bfin_can.c | 119 > +++++++++++++++++++++++++++++++++++++++++++- > 1 file changed, 118 insertions(+), 1 deletion(-) > > diff --git a/drivers/net/can/bfin_can.c b/drivers/net/can/bfin_can.c > index 0209c14..a676624 100644 > --- a/drivers/net/can/bfin_can.c > +++ b/drivers/net/can/bfin_can.c > @@ -20,7 +20,6 @@ > #include <linux/can/dev.h> > #include <linux/can/error.h> > > -#include <asm/bfin_can.h> > #include <asm/portmux.h> > > #define DRV_NAME "bfin_can" > @@ -28,6 +27,124 @@ > #define TX_ECHO_SKB_MAX 1 > > /* > + * transmit and receive channels > + */ > +#define TRANSMIT_CHL 24 > +#define RECEIVE_STD_CHL 0 > +#define RECEIVE_EXT_CHL 4 > +#define RECEIVE_RTR_CHL 8 > +#define RECEIVE_EXT_RTR_CHL 12 > +#define MAX_CHL_NUMBER 32 ^^^^^^^^^ Please use a common indention sheme, I suggest to use on space only.
Marc -- Pengutronix e.K. | Marc Kleine-Budde | Industrial Linux Solutions | Phone: +49-231-2826-924 | Vertretung West/Dortmund | Fax: +49-5121-206917-5555 | Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de |
signature.asc
Description: OpenPGP digital signature