Ian Kent <ik...@redhat.com> wrote: > To do this use the init process of the callers environment is used to setup > the namespaces in the same way the root init process is used otherwise.
This probably doesn't need both "use" and "used". > +struct task_struct *umh_get_init_pid(void) > +int umh_enter_ns(struct task_struct *tsk, struct cred *new) These are exported, so should probably have doc comments. > + this = file_open_root(mnt->mnt_root, mnt, path, O_RDONLY); You probably should explain in the patch description or in a comment in the function why we're opening the ns files rather than just going directly to current->nsproxy. David -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
