On Thu, Feb 05, 2015 at 11:39:21AM +0000, Lad Prabhakar wrote: > From: "Lad, Prabhakar" <[email protected]> > > this patch fixes following sparse warning: > > xen-acpi-processor.c:505:23: warning: symbol 'xen_acpi_processor_resume_nb' > was not declared. Should it be static?
Not sure if it is worth fixing it - as that whole code is only executed under normal PV guests - where it does not make sense for it be executed. That whole xen_resume_notifier should go away. > > Signed-off-by: Lad, Prabhakar <[email protected]> > --- > Found this issue on linux-next (gcc version 4.9.2, > sparse version 0.4.5-rc1)and applies on top linux-next. > > drivers/xen/xen-acpi-processor.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/xen/xen-acpi-processor.c > b/drivers/xen/xen-acpi-processor.c > index 59fc190..6c1f921 100644 > --- a/drivers/xen/xen-acpi-processor.c > +++ b/drivers/xen/xen-acpi-processor.c > @@ -502,7 +502,7 @@ static int xen_acpi_processor_resume(struct > notifier_block *nb, > return xen_upload_processor_pm_data(); > } > > -struct notifier_block xen_acpi_processor_resume_nb = { > +static struct notifier_block xen_acpi_processor_resume_nb = { > .notifier_call = xen_acpi_processor_resume, > }; > > -- > 1.9.1 > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
