On Wed, Jan 28, 2015 at 10:22:26PM -0500, Frederic Jacob wrote:
> Fix Sparse warnings for undeclared symbols
Huh?
>
> Signed-off-by: Frederic Jacob <frederic.jacob...@gmail.com>
> ---
> drivers/staging/fbtft/fb_hx8340bn.c | 2 +-
> drivers/staging/fbtft/fbtft_device.c | 4 ++--
> 2 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/staging/fbtft/fb_hx8340bn.c
> b/drivers/staging/fbtft/fb_hx8340bn.c
> index 3939502..26a987a 100644
> --- a/drivers/staging/fbtft/fb_hx8340bn.c
> +++ b/drivers/staging/fbtft/fb_hx8340bn.c
> @@ -108,7 +108,7 @@ static int init_display(struct fbtft_par *par)
> return 0;
> }
>
> -void set_addr_win(struct fbtft_par *par, int xs, int ys, int xe, int ye)
> +static void set_addr_win(struct fbtft_par *par, int xs, int ys, int xe, int
> ye)
> {
> fbtft_par_dbg(DEBUG_SET_ADDR_WIN, par,
> "%s(xs=%d, ys=%d, xe=%d, ye=%d)\n", __func__, xs, ys, xe, ye);
> diff --git a/drivers/staging/fbtft/fbtft_device.c
> b/drivers/staging/fbtft/fbtft_device.c
> index b9f4c30..157f79c 100644
> --- a/drivers/staging/fbtft/fbtft_device.c
> +++ b/drivers/staging/fbtft/fbtft_device.c
> @@ -29,8 +29,8 @@
>
> #define MAX_GPIOS 32
>
> -struct spi_device *spi_device;
> -struct platform_device *p_device;
> +static struct spi_device *spi_device;
> +static struct platform_device *p_device;
These changes are making things static, not undeclared. Can you fix up
your changelog entry to show the exact error you are fixing?
thanks,
greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
