Re: [PATCH V5 6/8] USB: f81232: clarify f81232_ioctl()

[Peter Hung]

Hello,

Sergei Shtylyov 於 2015/2/6 下午 08:21 寫道:
We extract TIOCGSERIAL section in f81232_ioctl() to
f81232_get_serial_info()
to make it clarify

    You're also changing 'ser.baud_rate' from 460800 to 115200. And
explicitly overriding some previously initialized to 0 fields.

F81232 max baudrate is only 115200bps, so I set it for
1.8432MHz/16 = 115200.

We had add some closing time referenced from serial_core.c. The default
value is:

port->close_delay     = HZ / 2;      /* .5 seconds */
port->closing_wait    = 30 * HZ;/* 30 seconds */

We had increasing close_delay about 10x to

port->close_delay     = 5 * HZ ;


The f81232_set_mctrl() replace set_control_lines() to do MCR control
so we clean-up the set_control_lines() function.

    I don't see where are you doing this...


This text is my patch V5 5/8 second section. I had wrong operation of 
copy & paste. It's doesn't need for this patch, sorry for it.

--
With Best Regards,
Peter Hung
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/