Signed-off-by: Stewart Smith <stew...@linux.vnet.ibm.com>
---
 arch/powerpc/include/asm/opal.h |   25 ++++++++++++++++---------
 1 file changed, 16 insertions(+), 9 deletions(-)

diff --git a/arch/powerpc/include/asm/opal.h b/arch/powerpc/include/asm/opal.h
index c09cf66..2aaa861 100644
--- a/arch/powerpc/include/asm/opal.h
+++ b/arch/powerpc/include/asm/opal.h
@@ -346,6 +346,11 @@ enum OpalPciResetScope {
 };
 
 enum OpalPciReinitScope {
+       /*
+        * Note: we chose values that do not overlap
+        * OpalPciResetScope as OPAL v2 used the same
+        * enum for both
+        */
        OPAL_REINIT_PCI_DEV = 1000
 };
 
@@ -423,10 +428,10 @@ enum {
 };
 
 struct opal_ipmi_msg {
-       uint8_t         version;
-       uint8_t         netfn;
-       uint8_t         cmd;
-       uint8_t         data[];
+       uint8_t version;
+       uint8_t netfn;
+       uint8_t cmd;
+       uint8_t data[];
 };
 
 /*
@@ -477,7 +482,6 @@ enum OpalMemErr_Version {
 enum OpalMemErrType {
        OPAL_MEM_ERR_TYPE_RESILIENCE    = 0,
        OPAL_MEM_ERR_TYPE_DYN_DALLOC,
-       OPAL_MEM_ERR_TYPE_SCRUB,
 };
 
 /* Memory Reilience error type */
@@ -731,11 +735,10 @@ struct OpalIoPhb3ErrorData {
        __be64 errorClass;
        __be64 correlator;
 
+       /* PHB3 MMIO Error Regs */
        __be64 nFir;                    /* 000 */
        __be64 nFirMask;                /* 003 */
        __be64 nFirWOF;         /* 008 */
-
-       /* PHB3 MMIO Error Regs */
        __be64 phbPlssr;                /* 120 */
        __be64 phbCsr;          /* 110 */
        __be64 lemFir;          /* C00 */
@@ -772,7 +775,7 @@ typedef struct oppanel_line {
 } oppanel_line_t;
 
 /*
- * SG entry
+ * SG entries
  *
  * WARNING: The current implementation requires each entry
  * to represent a block that is 4k aligned *and* each block
@@ -783,7 +786,11 @@ struct opal_sg_entry {
        __be64 length;
 };
 
-/* SG list */
+/*
+ * Candiate image SG list.
+ *
+ * length = VER | length
+ */
 struct opal_sg_list {
        __be64 length;
        __be64 next;
-- 
1.7.10.4

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Reply via email to