On Tue, Feb 10, 2015 at 05:26:03PM +0530, Sudip Mukherjee wrote: > initialiaze lcd parameters only if lcd is enabled. > > Signed-off-by: Sudip Mukherjee <[email protected]>
One minor comment below (cosmetic), but after this it's OK. Acked-by: Willy Tarreau <[email protected]> > + if (lcd.enabled) { > + /* > + * Init lcd struct with load-time values to preserve exact > + * current functionality (at least for now). > + */ > + lcd.height = lcd_height; > + lcd.width = lcd_width; > + lcd.bwidth = lcd_bwidth; > + lcd.hwidth = lcd_hwidth; > + lcd.charset = lcd_charset; > + lcd.proto = lcd_proto; > + lcd.pins.e = lcd_e_pin; > + lcd.pins.rs = lcd_rs_pin; > + lcd.pins.rw = lcd_rw_pin; > + lcd.pins.cl = lcd_cl_pin; > + lcd.pins.da = lcd_da_pin; > + lcd.pins.bl = lcd_bl_pin; > + > + /* Leave it for now, just in case */ ^^^^^^^^^^^^^^^^^^^ Please fix indenting the comment here. > + lcd.esc_seq.len = -1; > + } > + Willy -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
