Hi Stephen, On Mon, 09 Feb 2015 15:08:58 -0800 Stephen Boyd <sb...@codeaurora.org> wrote:
> On 02/09/15 14:51, Gilad Avidov wrote: > > pmic_arb v2 has no support for spmi non-data commands and thus > > returns -EOPNOTSUPP on .cmd callback. This causes a failure in > > spmi_drv_probe() which sends a wakeup command to the slave before > > probing its driver. This patchset removes the wakeup from > > spmi_drv_probe() since the spmi spec stipulates that a slaves > > default state is active and doesn't need a wakeup. > > The spec also seems to stipulate that SPMI masters shall support all > SPMI command sequences. > > > Gilad Avidov (2): > > spmi: remove wakeup command before slave probe > > spmi: pmic_arb: add support for hw version 2 > > > > .../bindings/spmi/qcom,spmi-pmic-arb.txt | 6 +- > > drivers/spmi/spmi-pmic-arb.c | 312 > > +++++++++++++++++---- > > drivers/spmi/spmi.c | 9 +- 3 files > > changed, 263 insertions(+), 64 deletions(-) > > > > Can you please include a patchset changelog here? What changed between > v2 and v3? > Changelog from v2 to v3: spmi-pmic-arb.c 1. Correct multiline comment style of the copyright at the top. 2. Remove redundant parenthesis around #define values and around m,n parameters of the version specific callbacks. 3. Remove useless comment. 4. pr_debug -> dev_dbg 5. corrected few indentations. 6. phys_addr_t offset -> u32 offset spmi.c 1. Correct multiline comment style of the copyright at the top. Thanks, Gilad -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
