On Fri, 13 Feb 2015, Jarkko Nikula wrote: > Surely GPIO irq will be used as an input pin so make sure its direction is > set after requesting. > > Signed-off-by: Jarkko Nikula <[email protected]> > --- > Again, I haven't seen any issue. Just a thought if BIOS haven't configured > the pin correctly. > --- > drivers/mfd/intel_soc_pmic_core.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-)
Applied, thanks. > diff --git a/drivers/mfd/intel_soc_pmic_core.c > b/drivers/mfd/intel_soc_pmic_core.c > index 40488e5b52ef..857e5cccdb49 100644 > --- a/drivers/mfd/intel_soc_pmic_core.c > +++ b/drivers/mfd/intel_soc_pmic_core.c > @@ -31,7 +31,7 @@ static int intel_soc_pmic_find_gpio_irq(struct device *dev) > struct gpio_desc *desc; > int irq; > > - desc = devm_gpiod_get_index(dev, "intel_soc_pmic", 0); > + desc = devm_gpiod_get_index(dev, "intel_soc_pmic", 0, GPIOD_IN); > if (IS_ERR(desc)) > return PTR_ERR(desc); > -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
