Re: [PATCH] x86/intel/quark: fix ptr_ret.cocci warnings

[Bryan O'Donoghue]

On 19/02/15 08:14, kbuild test robot wrote:

arch/x86/platform/intel-quark/imr.c:280:1-3: WARNING: PTR_ERR_OR_ZERO can be 
used


  Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR

Generated by: scripts/coccinelle/api/ptr_ret.cocci

CC: Bryan O'Donoghue <pure.lo...@nexus-software.ie>
Signed-off-by: Fengguang Wu <fengguang...@intel.com>
---

  imr.c |    5 +----
  1 file changed, 1 insertion(+), 4 deletions(-)

--- a/arch/x86/platform/intel-quark/imr.c
+++ b/arch/x86/platform/intel-quark/imr.c
@@ -277,10 +277,7 @@ static int imr_debugfs_register(struct i
  {
        idev->file = debugfs_create_file("imr_state", S_IFREG | S_IRUGO, NULL,
                                         idev, &imr_state_ops);
-       if (IS_ERR(idev->file))
-               return PTR_ERR(idev->file);
-
-       return 0;
+       return PTR_ERR_OR_ZERO(idev->file);
  }

  /**

This is a reasonable change.

ACK
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/