On 19/02/15 10:25, Ingo Molnar wrote:

-       ret = iosf_mbi_read(QRK_MBI_UNIT_MM, QRK_MBI_MM_READ,
+       return iosf_mbi_read(QRK_MBI_UNIT_MM, QRK_MBI_MM_READ,
                                reg++, &imr->wmask);
-       if (ret)
-               return ret;
-
-       return 0;
  }

  /**


This flow was a change asked for and supplied in review
feedback for Andy Shevchenko so NAK to this patch.

But this pattern:

        if (ret)
                return ret;

        return 0;

makes very little sense. Why is it done?

Thanks,

        Ingo

Feedback at review was that it's more consistent with the code that comes before.

So I changed it from

return iosf_mbi_read

to

ret = iosf_mbi_read

if (ret)
        return ret;
return 0;

as a result. I'm OK with the change suggested by the script if Andy (who requested the change) is.

--
Bryan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Reply via email to