On 20/02/15 16:01, Nicholas Mc Guire wrote: >>> pr_debug("%s(): task ending\n", __func__); >>> @@ -1460,7 +1460,7 @@ static void pxafb_disable_controller(struct >>> pxafb_info *fbi) >>> #ifdef CONFIG_FB_PXA_SMARTPANEL >>> if (fbi->lccr0 & LCCR0_LCDT) { >>> wait_for_completion_timeout(&fbi->refresh_done, >>> - 200 * HZ / 1000); >>> + msecs_to_jiffies(200); >> >> That will not compile.
> No compile warning or errors > > could you send me the compile error message and the toolchain you > are using - this change should not really have any noticable impact. I didn't compile it. It's missing a closing parenthesis. This is one reason I'm not very fond of cleanups to drivers that the patch sender cannot test... They may cause more problems than they help. Tomi
signature.asc
Description: OpenPGP digital signature