On Sun, 2015-02-22 at 04:41 +0000, Al Viro wrote: > On Sat, Feb 21, 2015 at 10:54:09PM -0500, Steven Rostedt wrote: > > On Sat, 21 Feb 2015 18:53:51 -0800 Joe Perches <[email protected]> wrote: > > > > > The seq_printf return value, because it's frequently misused, > > > will eventually be converted to void. > > > > > > See: commit 1f33c41c03da ("seq_file: Rename seq_overflow() to > > > seq_has_overflowed() and make public") > > > > > > Miscellanea: > > > > > > o Remove unused return value from trace_lookup_stack > > > > Acked-by: Steven Rostedt <[email protected]> > > FWIW, this one should be Cc:stable - it's a plain and simple bugfix > (so are all of those that used to return the result of seq_printf() from > ->show()).
Nah, it's not really a bugfix here. Patches sent to stable should fix actual bugs or failures. Sure, it's a defect, but it's only a logical one, not an actual one. It doesn't/can't fail in practice. This is only a single symbol and so it can't overflow the initial allocation. Besides that, the return value of the containing function is ignored. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
