Em Fri, Feb 27, 2015 at 07:53:46PM +0800, Yunlong Song escreveu:
> The recent new patch "perf tools: Add new 'perf data' command" (commit
> 2245bf14 in acme's git repo perf/core) has caused a building error when
> compiling the source code of perf:
>
> cc1: warnings being treated as errors
> builtin-data.c:89: error: missing initializer
> builtin-data.c:89: error: (near initialization for ‘data_cmds[1].summary’)
> make[2]: *** [builtin-data.o] Error 1
> make[2]: *** Waiting for unfinished jobs....
> LD bench/perf-in.o
> LD tests/perf-in.o
> make[1]: *** [perf-in.o] Error 2
> make: *** [all] Error 2
>
> This patch fixes the building error above.
>
> Signed-off-by: Yunlong Song <yunlong.s...@huawei.com>
> ---
> tools/perf/builtin-data.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/perf/builtin-data.c b/tools/perf/builtin-data.c
> index 9705ba7..0385063 100644
> --- a/tools/perf/builtin-data.c
> +++ b/tools/perf/builtin-data.c
> @@ -86,7 +86,7 @@ static int cmd_data_convert(int argc, const char **argv,
>
> static struct data_cmd data_cmds[] = {
> { "convert", "converts data file between formats", cmd_data_convert },
> - { NULL },
> + { NULL, NULL, NULL },
I guess here we could just do it as:
{ NULL, },
Will check and apply that instead, as it is more "future proof", i.e. if
a new field is introduced to this struct, one doesn't need to bother
updating the data_cmds array sentinel.
- Arnaldo
> };
>
> int cmd_data(int argc, const char **argv, const char *prefix)
> --
> 1.8.5.5
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majord...@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
