On Sat, 28 Feb, at 11:50:49AM, Borislav Petkov wrote: > > Yeah, too many hmms means this still needed staring at to find out what > exactly the problem is. And the problem is that allocating that struct > setup_data statically in arch/x86/boot/compressed/aslr.c works only by > chance, when the kernel decompressing doesn't overwrite that memory. Doing a static allocation is fine, and the memory is even reserved from being overwritten via memblock_x86_reserve_range_setup_data(), but it looks like that reservation gets dropped before get_setup_data_total_num() runs, which is what is causing ioremap() to complain - it really is usable RAM we're trying to ioremap().
Dropping the reservation looks to happen in memblock_x86_fill(), because you'll note that we explicitly reserve the boot services regions immediately after memblock_x86_fill() in setup_arch(). What isn't clear right now is why the ioremap() warning isn't triggering for a bunch of other callsites that get this wrong, i.e. pcibios_add_device(). -- Matt Fleming, Intel Open Source Technology Center -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
