* Valentin Rothberg <valentin.rothb...@lip6.fr> [150302 05:39]: > The IRQF_DISABLED flag is a NOOP and scheduled to be removed. According > to commit e58aa3d2d0cc ("genirq: Run irq handlers with interrupts > disabled") running IRQ handlers with interrupts enabled can cause stack > overflows when the interrupt line of the issuing device is still active. > > Signed-off-by: Valentin Rothberg <valentin.rothb...@lip6.fr>
Applying into omap-for-v4.1/l3 thanks. Regards, Tony > --- > drivers/bus/omap_l3_smx.c | 10 ++++------ > 1 file changed, 4 insertions(+), 6 deletions(-) > > diff --git a/drivers/bus/omap_l3_smx.c b/drivers/bus/omap_l3_smx.c > index 597fdae..360a5c0 100644 > --- a/drivers/bus/omap_l3_smx.c > +++ b/drivers/bus/omap_l3_smx.c > @@ -251,18 +251,16 @@ static int omap3_l3_probe(struct platform_device *pdev) > } > > l3->debug_irq = platform_get_irq(pdev, 0); > - ret = request_irq(l3->debug_irq, omap3_l3_app_irq, > - IRQF_DISABLED | IRQF_TRIGGER_RISING, > - "l3-debug-irq", l3); > + ret = request_irq(l3->debug_irq, omap3_l3_app_irq, IRQF_TRIGGER_RISING, > + "l3-debug-irq", l3); > if (ret) { > dev_err(&pdev->dev, "couldn't request debug irq\n"); > goto err1; > } > > l3->app_irq = platform_get_irq(pdev, 1); > - ret = request_irq(l3->app_irq, omap3_l3_app_irq, > - IRQF_DISABLED | IRQF_TRIGGER_RISING, > - "l3-app-irq", l3); > + ret = request_irq(l3->app_irq, omap3_l3_app_irq, IRQF_TRIGGER_RISING, > + "l3-app-irq", l3); > if (ret) { > dev_err(&pdev->dev, "couldn't request app irq\n"); > goto err2; > -- > 1.9.1 > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/