On Thu, 2015-02-26 at 07:44 -0700, Toshi Kani wrote: > On Thu, 2015-02-26 at 12:30 +0100, Ingo Molnar wrote: > > * Toshi Kani <[email protected]> wrote: > > > > > On Wed, 2015-02-25 at 08:22 +0100, Ingo Molnar wrote: > > > > * Toshi Kani <[email protected]> wrote: > > > > > > > > > +int set_pages_array_wt(struct page **pages, int addrinarray) > > > > > +{ > > > > > + return _set_pages_array(pages, addrinarray, > > > > > _PAGE_CACHE_MODE_WT); > > > > > +} > > > > > +EXPORT_SYMBOL(set_pages_array_wt); > > > > > > > > So by default we make new APIs EXPORT_SYMBOL_GPL(): we > > > > don't want proprietary modules mucking around with new code > > > > PAT interfaces, we only want modules we can analyze and fix > > > > in detail. > > > > > > Right. I have one question for this case. This > > > set_pages_array_wt() extends the set_pages_array_xx() > > > family, which are all exported with EXPORT_SYMBOL() > > > today. In this case, should we keep them exported in the > > > consistent manner, or should we still use GPL when adding > > > a new one? > > > > Still keep it GPL, it's a new API that old modules > > obviously don't use. > > Got it. Thanks for the clarification.
Since this is a minor change and there is no other comment at this point, I've submitted the updated patch 7/7 alone with the following subject for saving your mail box. :-) [PATCH v8-UPDATE 7/7] x86, mm: Add set_memory_wt() for WT Thanks, -Toshi -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
