>>> On 05.03.15 at 08:23, <[email protected]> wrote:
> It's a bit pointless to allow Kconfig configuration for 1GB kernel
> mappings, it's already hidden behind a 'default y' and CONFIG_EXPERT.
>
> Remove this complication and simplify the code by renaming
> CONFIG_ENABLE_DIRECT_GBPAGES to CONFIG_X86_DIRECT_GBPAGES and
> document the DEBUG_PAGE_ALLOC and KMEMCHECK quirks.
>
> Cc: Luis R. Rodriguez <[email protected]>
> Cc: Andrew Morton <[email protected]>
> Cc: Andy Lutomirski <[email protected]>
> Cc: Borislav Petkov <[email protected]>
> Cc: Borislav Petkov <[email protected]>
> Cc: Dave Hansen <[email protected]>
> Cc: David Vrabel <[email protected]>
> Cc: Dexuan Cui <[email protected]>
> Cc: Greg Kroah-Hartman <[email protected]>
> Cc: H. Peter Anvin <[email protected]>
> Cc: [email protected]
> Cc: Jan Beulich <[email protected]>
> Cc: Joonsoo Kim <[email protected]>
> Cc: Juergen Gross <[email protected]>
> Cc: Linus Torvalds <[email protected]>
> Cc: Pavel Machek <[email protected]>
> Cc: Thomas Gleixner <[email protected]>
> Cc: Tony Lindgren <[email protected]>
> Cc: Toshi Kani <[email protected]>
> Cc: Vlastimil Babka <[email protected]>
> Cc: Xishi Qiu <[email protected]>
> Cc: [email protected]
> Signed-off-by: Ingo Molnar <[email protected]>
> ---
> arch/x86/Kconfig | 23 +++++++----------------
> arch/x86/mm/init.c | 7 +------
> 2 files changed, 8 insertions(+), 22 deletions(-)
>
> diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig
> index 4d06e1c8294a..54d528a37ff4 100644
> --- a/arch/x86/Kconfig
> +++ b/arch/x86/Kconfig
> @@ -1299,22 +1299,13 @@ config ARCH_DMA_ADDR_T_64BIT
> def_bool y
> depends on X86_64 || HIGHMEM64G
>
> -config ENABLE_DIRECT_GBPAGES
> - def_bool y
> - depends on X86_64 && !DEBUG_PAGEALLOC && !KMEMCHECK
> -
> -config DIRECT_GBPAGES
> - bool "Enable 1GB pages for kernel pagetables" if EXPERT
> - default y
> - depends on ENABLE_DIRECT_GBPAGES
> - ---help---
> - Enable by default the kernel linear mapping to use 1GB pages on CPUs
> - that support it. This can improve the kernel's performance a tiny bit
> - by reducing TLB pressure. If in doubt, say "Y". If you've disabled
> - option but your platform is capable of handling support for this
> - you can use the gbpages kernel parameter. Likewise if you've enabled
> - this but you'd like to force disable this option you can use the
> - nogbpages kernel parameter.
> +config X86_DIRECT_GBPAGES
> + def_bool (X86_64 && !DEBUG_PAGEALLOC && !KMEMCHECK)
config X86_DIRECT_GBPAGES
def_bool y
depends on X86_64 && !DEBUG_PAGEALLOC && !KMEMCHECK
or else it'll leave a pointless
# CONFIG_X86_DIRECT_GBPAGES is not set
in .config-s where the dependencies are not met.
Jan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
