On Fri, 2015-03-06 at 19:17 +0100, Peter Senna Tschudin wrote:
> On my test environment the troughput of a file transfer drops from
> 4.4Mbps to 116Kbps due the number of repeated warning messages.
> Adding printk_ratelimit() solves the issue without removing the
> warning message.
What value is there for this message being emitted more than once?
> diff --git a/drivers/net/ethernet/broadcom/bgmac.c
> b/drivers/net/ethernet/broadcom/bgmac.c
> @@ -302,7 +302,7 @@ static int bgmac_dma_rx_skb_for_slot(struct bgmac *bgmac,
> slot->skb = skb;
> slot->dma_addr = dma_addr;
>
> - if (slot->dma_addr & 0xC0000000)
> + if ((slot->dma_addr & 0xC0000000) && printk_ratelimit())
> bgmac_warn(bgmac, "DMA address using 0xC0000000 bit(s), it may
> need translation trick\n");
Maybe better as a static function
static void check_translate_address(struct bgmac *bgmac, dma_addr_t addr)
{
static bool printed;
if (!printed && (addr & (dma_addr_t)0xC0000000)))
printed = true;
bgmac_warn(bgmac, etc...);
}
}
[...]
check_translate_address(bgmac, slot->dma_addr);
> return 0;
> @@ -505,7 +505,7 @@ static int bgmac_dma_alloc(struct bgmac *bgmac)
> ring->mmio_base);
> goto err_dma_free;
> }
> - if (ring->dma_base & 0xC0000000)
> + if ((ring->dma_base & 0xC0000000) && printk_ratelimit())
> bgmac_warn(bgmac, "DMA address using 0xC0000000 bit(s),
> it may need translation trick\n");
>
> ring->unaligned = bgmac_dma_unaligned(bgmac, ring,
> @@ -536,7 +536,7 @@ static int bgmac_dma_alloc(struct bgmac *bgmac)
> err = -ENOMEM;
> goto err_dma_free;
> }
> - if (ring->dma_base & 0xC0000000)
> + if ((ring->dma_base & 0xC0000000) && printk_ratelimit())
> bgmac_warn(bgmac, "DMA address using 0xC0000000 bit(s),
> it may need translation trick\n");
>
> ring->unaligned = bgmac_dma_unaligned(bgmac, ring,
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
