Hi, On Fri, Mar 06, 2015 at 04:03:24PM +0530, Jenny TC wrote: > Charging current (CC) and charging voltage (CV) may vary based on > battery temperature. To support CC and CV for different temperature > zones, defined a charging object which holds the properties related > to battery charging. > > Signed-off-by: Jenny TC <[email protected]> > --- > include/linux/power_supply.h | 27 +++++++++++++++++++++++++++ > 1 file changed, 27 insertions(+) > > diff --git a/include/linux/power_supply.h b/include/linux/power_supply.h > index 096dbce..7aada44 100644 > --- a/include/linux/power_supply.h > +++ b/include/linux/power_supply.h > @@ -252,6 +252,33 @@ struct power_supply_info { > int use_for_apm; > }; > > + > +struct psy_temp_mon_table { > + int temp_max; > + int temp_min; > + int charging_current; /* CC */ > + int charging_voltage; /* CV */ > + /* delta voltage at which charging should restart */ > + int maint_voltage_delta; > +}; > + > +#define PSY_MAX_BAT_NAME_LEN 8 > +#define PSY_MAX_TEMP_ZONE 6 > + > +struct psy_charging_obj {
This is not just about charging data, but also about the batteries
thermal limits, technology and full capacity, so how about
struct psy_battery_information {
> + char name[PSY_MAX_BAT_NAME_LEN];
char *name;
No need for arbitrary length limitation.
> + int battery_type;
> + int temp_max;
> + int temp_min;
> + int full_condition_soc;
Please be more verbose about the information being stored here.
> + int full_condition_capacity;
> + int full_condition_voltage;
> + int iterm; /* charge termination current */
> + /* CC/CV table for different temperature range */
> + int temp_mon_count; /* number of entries in temp_mon_table */
> + struct psy_temp_mon_table temp_mon_table[PSY_MAX_TEMP_ZONE];
No need to embed this into the struct. Just point to the array and
remove the size limitation.
> +};
> +
> extern struct atomic_notifier_head power_supply_notifier;
> extern int power_supply_reg_notifier(struct notifier_block *nb);
> extern void power_supply_unreg_notifier(struct notifier_block *nb);
-- Sebastian
signature.asc
Description: Digital signature
