>> (Find source files, expand tab chars to their on-screen length, print if >> >= 80, count lines) > >The bulk of the longest lines are in the sound and drivers subtrees. >One example on the "high end", with 546 chars in one line: > >== >drivers/scsi/BusLogic.c: > %2d %5d %5d %5d %5d %5d %5d %5d %5d %5d\n", TargetID, > TargetStatistics[TargetID].CommandAbortsRequested, > TargetStatistics[TargetID].CommandAbortsAttempted, > TargetStatistics[TargetID].CommandAbortsCompleted, > TargetStatistics[TargetID].BusDeviceResetsRequested, > TargetStatistics[TargetID].BusDeviceResetsAttempted, > TargetStatistics[TargetID].BusDeviceResetsCompleted, > TargetStatistics[TargetID].HostAdapterResetsRequested, > TargetStatistics[TargetID].HostAdapterResetsAttempted, > TargetStatistics[TargetID].HostAdapterResetsCompleted); >==
this is omg. - the VLN BASIC way (very long variable names) - it could have been splitted at the next possible space at 80, i.e. mostly after a comma (my mail _reader_ automatically wrapped it, so it looked rather ok - until I took an _editor_) If I add a temporary (as suggested by rule 3) (struct BusLogic_Statistics *tp = &TargetStatistics[TargetID]), the line length loses a lot of weight: 339 chars. > %2d %5d %5d %5d %5d %5d %5d %5d %5d %5d\n", TargetID, > TargetStatistics[TargetID].CommandAbortsRequested, > TargetStatistics[TargetID].CommandAbortsAttempted, > TargetStatistics[TargetID].CommandAbortsCompleted, > TargetStatistics[TargetID].BusDeviceResetsRequested, > TargetStatistics[TargetID].BusDeviceResetsAttempted, > TargetStatistics[TargetID].BusDeviceResetsCompleted, > TargetStatistics[TargetID].HostAdapterResetsRequested, > TargetStatistics[TargetID].HostAdapterResetsAttempted, > TargetStatistics[TargetID].HostAdapterResetsCompleted); Jan Engelhardt -- - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
