On Tue, Mar 10, 2015 at 9:16 AM, John Stoffel <[email protected]> wrote: >>>>>> "Andy" == Andy Lutomirski <[email protected]> writes: > > Andy> As far as I can tell, these fields have been set to zero on save and > Andy> ignored on restore since Linux was imported into git. Rename them > Andy> '__pad1' and '__pad2' to avoid confusion and to allow them to be > Andy> recycled some day. > > Andy> I'm intentionally avoiding calling either of them __pad0: the field > Andy> formerly known as __pad0 is now ss. > > Andy> Signed-off-by: Andy Lutomirski <[email protected]> > Andy> --- > Andy> arch/x86/include/asm/sigcontext.h | 4 ++-- > Andy> arch/x86/include/uapi/asm/sigcontext.h | 4 ++-- > Andy> arch/x86/kernel/signal.c | 4 ++-- > Andy> 3 files changed, 6 insertions(+), 6 deletions(-) > > Andy> diff --git a/arch/x86/include/asm/sigcontext.h > b/arch/x86/include/asm/sigcontext.h > Andy> index f910cdcb71fd..5f0ef11719e1 100644 > Andy> --- a/arch/x86/include/asm/sigcontext.h > Andy> +++ b/arch/x86/include/asm/sigcontext.h > Andy> @@ -57,8 +57,8 @@ struct sigcontext { > Andy> unsigned long ip; > Andy> unsigned long flags; > Andy> unsigned short cs; > Andy> - unsigned short gs; > Andy> - unsigned short fs; > Andy> + unsigned short __pad2; /* Was called gs, but was always zero. */ > Andy> + unsigned short __pad1; /* Was called gs, but was always zero. */ > > Shouldn't this comment read: > > /* Was called fs, but was always zero. */ > > for the second one?
Will fix for v2. Thanks. -- Andy Lutomirski AMA Capital Management, LLC -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
