On 03/10/2015 05:36 PM, Michael Ellerman wrote: > On Mon, 2015-03-09 at 16:49 -0600, Shuah Khan wrote: >> On 03/09/2015 08:28 AM, Shuah Khan wrote: >>> On 03/04/2015 03:19 AM, Michael Ellerman wrote: >>>> The makefiles under tools/testing/selftests are not real kbuild >>>> makefiles, they are regular stand alone makefiles. As such they *do* >>>> want all the standard implicit rules and variables defined. >>>> >>>> So before calling those makefiles, filter -rR out of MAKEFLAGS. >>>> >>>> Without this not all the selftests are built correctly when called via >>>> the top-level Makefile. >>>> >>>> Signed-off-by: Michael Ellerman <m...@ellerman.id.au> >>> >>> Hi Michal, >>> >>> Could you please take this patch in your tree. >>> >>> Acked-by: Shuah Khan <shua...@osg.samsung.com> >>> >> >> I am changing this to a Nack. This is not fully cooked. >> I am seeing new failures on some tests. >> >> gcc: error: elf_x86_64: No such file or directory >> gcc: error: unrecognized command line option ‘-m’ > > I can't reproduce that here. In what way do you think it's related to this > patch? > > cheers
I have just your patch on tops of linux 4.0-rc3 and ran make kselftest and that's what I see. If you can fix this problem I can take your patch, otherwise, I have to go with individual Makefiles fixes. -- Shuah -- Shuah Khan Sr. Linux Kernel Developer Open Source Innovation Group Samsung Research America (Silicon Valley) shua...@osg.samsung.com | (970) 217-8978 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
