Michal Schmidt wrote:
Pavel Machek wrote:
Hi!
I'd like to get this tested under as many configurations as
possible. With this, your hdd should no longer do "yoyo" (spindown,
spinup, spindown) during suspend...
It looks like the patch is now in -mm (I use 2.6.13-rc3-mm1).
But my disks still yoyo during suspend. What more is needed? Some patch
to ide-disk.c ?
I think I've found the problem.
The attached patch stops the disks from spinning down and up on suspend.
The patch applies to 2.6.13-rc3-mm1.
Signed-off-by: Michal Schmidt <[EMAIL PROTECTED]>
diff -Nurp -X dontdiff.new linux-mm/drivers/ide/ide-io.c linux-mm.mich/drivers/ide/ide-io.c
--- linux-mm/drivers/ide/ide-io.c 2005-06-30 01:00:53.000000000 +0200
+++ linux-mm.mich/drivers/ide/ide-io.c 2005-07-21 16:59:46.000000000 +0200
@@ -150,7 +150,7 @@ static void ide_complete_power_step(ide_
switch (rq->pm->pm_step) {
case ide_pm_flush_cache: /* Suspend step 1 (flush cache) complete */
- if (rq->pm->pm_state == 4)
+ if (rq->pm->pm_state == PM_EVENT_FREEZE)
rq->pm->pm_step = ide_pm_state_completed;
else
rq->pm->pm_step = idedisk_pm_standby;
