On Wed, Mar 11, 2015 at 10:04 AM, Shuah Khan <shua...@osg.samsung.com> wrote: > On 03/11/2015 10:53 AM, John Stultz wrote: >> On Wed, Mar 11, 2015 at 9:43 AM, Shuah Khan <shua...@osg.samsung.com> wrote: >>> On 03/02/2015 02:09 PM, John Stultz wrote: >>>> I've hosted my timekeeping tests on github for the last few years: >>>> https://github.com/johnstultz-work/timetests >>>> >>>> but I suspect not too many folks have actually used them. >>>> >>>> I've been meaning to get them reworked and submitted into the >>>> selftest infrastructure, but haven't had much time until >>>> recently. >>>> >>>> I've added both the non-desctructive and destructive tests >>>> (which set the time, possibly to strange values, or tries >>>> to trigger historical issues that could crash the machine). >>>> The destructive tests are run (as root, or with proper >>>> privledge) via: >>>> # make run_destructive_tests >>>> >>>> Changes in v3: >>>> * Lots of -Wall build warning fixups >>>> * Handle the CROSS_COMPILER build variable properly >>>> (Thanks to LinusW for pointing that out) >>>> * Integrate w/ ksft_exit_* infrastructure >>>> >>>> Let me know if there is any further comments or feedback! >>>> >>> >>> Ran into several checkpatch warnings when I tried to queue >>> these up for 4.1. Could you please fix them and resend. >> >> So the only few items I saw were: >> 1) Lines over 80 col, usually do to long string output >> 2) String output split over multiple lines (result of trying to fix #1 >> in a few spots) >> - And here I did try to split the string sanely so I didn't break >> up the messages, so they're still grepable >> 3) The extern char *optarg, warning. This one I can probably kill >> since I'm including unistd.h. >> >> I'll take a look at #3, but #1 and #2 are basically contrary at a >> certain point. Or do you have other ideas for resolving those >> warnings? > > Here are the errors git am flagged: > > Patch07: > Applying: selftests/timers: Add set-timer-lat test from timetest suite > /lkml/linux_4.0/.git/rebase-apply/patch:246: new blank line at EOF. > + > warning: 1 line adds whitespace errors. > > Patch11 > Applying: selftests/timers: Add alarmtimer-suspend test from timetests suite > /lkml/linux_4.0/.git/rebase-apply/patch:222: new blank line at EOF. > + > warning: 1 line adds whitespace errors. > > Patch18 > Applying: selftests/timers: Add set-2038 test from timetest suite > /lkml/linux_4.0/.git/rebase-apply/patch:180: new blank line at EOF. > + > warning: 1 line adds whitespace errors. >
Hrm.. Not sure why I didn't see those earlier. My apologies, I will definitely fix those up. Thanks for letting me know! thanks -john -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/