On Wed, Mar 11, 2015 at 2:00 PM, George Joseph <[email protected]> wrote: > When a transmit queue timeout happens, dev_watchdog calls fec_timeout > which in turns schedules fec_enet_timeout_work. fec_enet_timeout_work > uses container_of to get the private data structure (fep) then tries to > use fep->netdev. Unfortunately, nobody ever set fep->netdev so the result > is a NULL pointer oops. > > With fep->netdev set right after fep is allocated in fep_probe, the > drivers recovers nicely after the tx queue timeout. > > Signed-off-by: George Joseph <[email protected]> > Tested-by: George Joseph <[email protected]>
Thanks for the patch, but this has already been fixed by: commit 0c8185944a125621a1766615585238a3563ccac3 Author: Hubert Feurstein <[email protected]> Date: Wed Jan 7 14:48:17 2015 +0100 net: fec: fix NULL pointer dereference in fec_enet_timeout_work This patch initialises the fep->netdev pointer. This pointer was not initialised at all, but is used in fec_enet_timeout_work and in some error paths. Signed-off-by: Hubert Feurstein <[email protected]> Signed-off-by: David S. Miller <[email protected]> -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
