Em Fri, Mar 13, 2015 at 08:34:41AM +0100, Ingo Molnar escreveu:
> * Arnaldo Carvalho de Melo <[email protected]> wrote:
> > From: Andi Kleen <[email protected]>
> > +static void print_running(u64 run, u64 ena)
> > +{
> > + if (csv_output) {
> > + fprintf(output, "%s%" PRIu64 "%s%.2f",
> > + csv_sep,
> > + run,
> > + csv_sep,
> > + ena ? 100.0 * run / ena : 100.0);
> > + } else if (run != ena)
> > + fprintf(output, " (%.2f%%)", 100.0 * run / ena);
> That's not the standard pattern for 'else if' branches, but:
>
> } else {
> if ()
> ...
> }
>
> to make it stand apart more from a simple 'else' branch.
I think it is preferred to make it match the if branch if it uses curly
braces, i.e. make it look:
} else if () {
}
i.e switch like series of else if, to avoid too much indentation for such
constructs.
Fixed it and the other file, redid the perf-core-for-mingo tag, pushed.
- Arnaldo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
