On Fri, 13 Mar 2015, Joe Perches wrote:
> Currently checkpatch will fuss if one uses world writable
> settings in debugfs files and DEVICE_ATTR uses by testing
> S_IWUGO but not testing S_IWOTH, S_IRWXUGO or S_IALLUGO.
>
> Extend the check to catch all cases exporting world writable
> permissions including octal values.
>
> Original-patch-by: Nicholas Mc Guire <hof...@osadl.org>
> Signed-off-by: Joe Perches <j...@perches.com>
> ---
> scripts/checkpatch.pl | 12 ++++++++++--
> 1 file changed, 10 insertions(+), 2 deletions(-)
>
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> index 6b79beb..4f07d50 100755
> --- a/scripts/checkpatch.pl
> +++ b/scripts/checkpatch.pl
> @@ -443,6 +443,14 @@ foreach my $entry (@mode_permission_funcs) {
> $mode_perms_search .= $entry->[0];
> }
>
> +$our $mode_perms_world_writable = qr{
> + S_IWUGO |
> + S_IWOTH |
> + S_IRWXUGO |
> + S_IALLUGO |
> + 0[0-7][0-7][2367]
> +}x;
> +
> our $allowed_asm_includes = qr{(?x:
> irq|
> memory|
> @@ -5356,8 +5364,8 @@ sub process {
> }
> }
>
> - if ($line =~ /debugfs_create_file.*S_IWUGO/ ||
> - $line =~ /DEVICE_ATTR.*S_IWUGO/ ) {
> + if ($line =~
> /debugfs_create_\w+.*\b$mode_perms_world_writable\b/ ||
> + $line =~ /DEVICE_ATTR.*\b$mode_perms_world_writable\b/) {
> WARN("EXPORTED_WORLD_WRITABLE",
> "Exporting world writable files is usually an
> error. Consider more restrictive permissions.\n" . $herecurr);
> }
>
>
yup - thats definitely the clearner solution!
thx!
hofrat
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
