Hi Sylvain, > -----Original Message----- > From: Sylvain Rochet [mailto:sylvain.roc...@finsecur.com] > Sent: 2015年3月16日 18:21 > To: Yang, Wenyou > Cc: Ferre, Nicolas; li...@arm.linux.org.uk; > linux-arm-ker...@lists.infradead.org; > linux-kernel@vger.kernel.org; alexandre.bell...@free-electrons.com; > p...@axentia.se; sergei.shtyl...@cogentembedded.com; li...@maxim.org.za > Subject: Re: [PATCH v2.0 1/2] pm: at91: add the PM initialization for the > sama5d3 > and sama5d4 > > Hello Wenyou, > > On Mon, Mar 09, 2015 at 11:57:08AM +0800, Wenyou Yang wrote: > > To get the mpddrc peripheral id from the PM initialization, which will > > be used to disable mpddrc'c clock during suspending. > > > +void __init sam5d3_pm_init(void) > > +{ > > + at91_dt_ramc(); > > + at91_pm_data.uhp_udp_mask = AT91SAM926x_PMC_UHP | > AT91SAM926x_PMC_UDP; > > + at91_pm_data.memctrl = AT91_MEMCTRL_DDRSDR; > > + at91_pm_data.ddrc_pid = SAMA5D3_ID_MPDDRC; > > + return at91_pm_init(); > > +} > > + > > +void __init sam5d4_pm_init(void) > > +{ > > + at91_dt_ramc(); > > + at91_pm_data.uhp_udp_mask = AT91SAM926x_PMC_UHP | > AT91SAM926x_PMC_UDP; > > + at91_pm_data.memctrl = AT91_MEMCTRL_DDRSDR; > > + at91_pm_data.ddrc_pid = SAMA5D4_ID_MPDDRC; > > + at91_pm_data.is_sama5d4 = true; > > + return at91_pm_init(); > > +} > > > +static void __init sama5d4_dt_device_init(void) { > > + of_platform_populate(NULL, of_default_bus_match_table, NULL, NULL); > > + sam5d4_pm_init(); > > +} > > This doesn't look right, where is sam5d3_pm_init() actually used ? Oh, I missed it mindlessly during rebasing. I will added it in the next version.
Sorry for being confused. > > Sylvain Best Regards, Wenyou Yang
