On Wed, Mar 18, 2015 at 02:21:08PM +0100, Quentin Lambert wrote: > The refactoring intrduced in > c84a083b995b ("Staging: dgnc: Use goto for spinlock release before return") > inverts the order in which the lock is released and ld is tested for nullity. > > This patch restores the execution flow. >
This changelog still doesn't make sense so I took a look at the code. tty_ldisc_deref() is an unlock function. So this is a lock ordering bug. What makes you think the original ordering was correct? Who reported this bug? What are the effects of this bug? Please answer the questions and we can work together on a proper fix if needed. regards, dan carpenter -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/