> > +#include <linux/module.h>
>
> So is this include needed?
I can change it to linux/kmod.h. We'll still do the request_module
call even after these changes.
> > +static int __init ulpi_init(void)
> > +{
> > + return bus_register(&ulpi_bus);
> > +}
> > +module_init(ulpi_init);
>
> This will be equivalent to
> __initcall(ulpi_init)
>
> according to include/linux/init.h.
I'll change it to subsys_initcall(ulpi_init).
> > +static void __exit ulpi_exit(void)
> > +{
> > + bus_unregister(&ulpi_bus);
> > +}
> > +module_exit(ulpi_exit);
>
> This will never be called.
>
> > +MODULE_AUTHOR("Intel Corporation");
> > +MODULE_LICENSE("GPL v2");
> > +MODULE_DESCRIPTION("USB ULPI PHY bus");
>
> And these three macros will be, effectively, preprocessed away.
True. I'll drop them.
Thanks,
--
heikki
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
