On Fri, 2015-03-20 at 13:43 +0100, Richard Weinberger wrote: > Sergej, > > On Fri, Mar 20, 2015 at 1:10 PM, <[email protected]> wrote: > > mkopci (MB11.xx) device (RC Module project) provides data transference > > through a serial bus bar according to MIL-STD-1553. > > the driver used for operating devices, reads PCI configuration space and > > pass interrupts to user-space applications. > > > > Please consider adding this patch to the linux-next queue. > > From a quick look I'd suggest to get the driver first in shape. > > - You add new proc files, which is not really welcomed. Please consider sysfs. > - In the debug prints you compare against current->comm, also not nice. > - You use printk() in the interrupt handler. > - Why is this a misc driver at all? Does it really not fit into any > other device class? > - I'm sure running checkpatch.pl against the patch would also not hurt. :) And an additional, trivial, change you might also consider is using MODULE_LICENSE("GPL v2");
as that would match the license stated in the comment at the top of drivers/misc/mkopci.c. Paul Bolle -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
