Am 21.03.2015 um 23:06 schrieb L. Alberto Giménez: > On Sat, Mar 21, 2015 at 10:40:46PM +0100, Richard Weinberger wrote: >> Huh? Since when? > > There are a lot of cases where a too generic goto label for cleanup > causes a bug or makes debugging harder. > > Last time was this G+ post, by Dan Carpenter: > > https://plus.google.com/106378716002406849458/posts/DfuAkt8szf2 > > >> rw@azrael:~/linux (for-v4.1/uml_misc $)> git grep -e "goto out;" | wc -l >> 26667 >> rw@azrael:~/linux (for-v4.1/uml_misc $)> git grep -e "goto fail;" | wc -l >> 3733 > > If something is already in the kernel code, does that mean that it's OK? > I honestly don't think so, and I think that goto labels for cleanup exit > paths should be a little more descriptive.
I disagree. out and exit are perfectly fine labels. >> What is next? Variable name "i" considered harmful? > > No one complained about that so far. I might add that to checkpatch.pl > if needed. I *really* *really* hope you're kidding. >> Can we please stop this nonsense. > > It's just a proposal for a warning. If it is really not needed, it won't > be applied and life will go on :) checkpatch.pl is already more than annoying. It used to be a nice tool but it becomes more and more an harassment for guys who actually work on the kernel. Thanks, //richard -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
