Hey Thomas,

On 24-03-15 22:23, Thomas Niederprüm wrote:
This patch adds ssd1307fb_blank() to make the framebuffer capable
of blanking.

Signed-off-by: Thomas Niederprüm <nied...@physik.uni-kl.de>
---
  drivers/video/fbdev/ssd1307fb.c | 13 +++++++++++++
  1 file changed, 13 insertions(+)

diff --git a/drivers/video/fbdev/ssd1307fb.c b/drivers/video/fbdev/ssd1307fb.c
index 061cc95..9101b27 100644
--- a/drivers/video/fbdev/ssd1307fb.c
+++ b/drivers/video/fbdev/ssd1307fb.c
@@ -238,6 +238,18 @@ static ssize_t ssd1307fb_write(struct fb_info *info, const 
char __user *buf,
        return count;
  }

+static int ssd1307fb_blank(int blank_mode, struct fb_info *info)
+{
+       struct ssd1307fb_par *par = info->par;
+       int ret;
+
+       if (blank_mode != FB_BLANK_UNBLANK)
+               ret = ssd1307fb_write_cmd(par->client, SSD1307FB_DISPLAY_OFF);
+       else
+               ret = ssd1307fb_write_cmd(par->client, SSD1307FB_DISPLAY_ON);
I'd probably add an extra return, or drop the ret var at all and just return the function.

or even shorter :)
return sd1307fb_write_cmd(par->client, (blank_mode != FB_BLANK_UNBLANK) ? SSD1307FB_DISPLAY_OFF : SSD1307FB_DISPLAY_ON;

Olliver
+       return ret;
+}
+
  static void ssd1307fb_fillrect(struct fb_info *info, const struct fb_fillrect 
*rect)
  {
        struct ssd1307fb_par *par = info->par;
@@ -263,6 +275,7 @@ static struct fb_ops ssd1307fb_ops = {
        .owner          = THIS_MODULE,
        .fb_read        = fb_sys_read,
        .fb_write       = ssd1307fb_write,
+       .fb_blank       = ssd1307fb_blank,
        .fb_fillrect    = ssd1307fb_fillrect,
        .fb_copyarea    = ssd1307fb_copyarea,
        .fb_imageblit   = ssd1307fb_imageblit,


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Reply via email to