On Fri, Mar 20, 2015 at 04:50:32PM -0700, Andy Lutomirski wrote: > On Fri, Mar 20, 2015 at 4:17 PM, Luis R. Rodriguez > <[email protected]> wrote: > > From: "Luis R. Rodriguez" <[email protected]> > > > > This lets drivers take advanate of PAT when available. This > > should help with the transition of converting video drivers over > > to ioremap_wc() to help with the goal of eventually using > > _PAGE_CACHE_UC over _PAGE_CACHE_UC_MINUS on x86 on > > ioremap_nocache() (de33c442e) > > > > Cc: Suresh Siddha <[email protected]> > > Cc: Venkatesh Pallipadi <[email protected]> > > Cc: Ingo Molnar <[email protected]> > > Cc: Thomas Gleixner <[email protected]> > > Cc: Juergen Gross <[email protected]> > > Cc: Daniel Vetter <[email protected]> > > Cc: Andy Lutomirski <[email protected]> > > Cc: Dave Airlie <[email protected]> > > Cc: Antonino Daplas <[email protected]> > > Cc: Jean-Christophe Plagniol-Villard <[email protected]> > > Cc: Tomi Valkeinen <[email protected]> > > Cc: [email protected] > > Cc: [email protected] > > Signed-off-by: Luis R. Rodriguez <[email protected]> > > --- > > drivers/pci/pci.c | 14 ++++++++++++++ > > include/linux/pci.h | 1 + > > 2 files changed, 15 insertions(+) > > > > diff --git a/drivers/pci/pci.c b/drivers/pci/pci.c > > index 81f06e8..6afd507 100644 > > --- a/drivers/pci/pci.c > > +++ b/drivers/pci/pci.c > > @@ -137,6 +137,20 @@ void __iomem *pci_ioremap_bar(struct pci_dev *pdev, > > int bar) > > pci_resource_len(pdev, bar)); > > } > > EXPORT_SYMBOL_GPL(pci_ioremap_bar); > > + > > +void __iomem *pci_ioremap_wc_bar(struct pci_dev *pdev, int bar) > > +{ > > + /* > > + * Make sure the BAR is actually a memory resource, not an IO > > resource > > + */ > > + if (!(pci_resource_flags(pdev, bar) & IORESOURCE_MEM)) { > > + WARN_ON(1); > > + return NULL; > > + } > > if (WARN_ON(...))?
Sure, they are equivalent however this follows the same exact style as pci_ioremap_bar() so if we change this one might as well change the style of pci_ioremap_bar() as well. Let me know if there is any preference. I personally don't mind the extra line as it shortens the check. Luis -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
