On Thu, Mar 26, 2015 at 11:41:24AM +0100, Belisko Marek wrote: > On Thu, Mar 26, 2015 at 10:53 AM, Greg KH <gre...@linuxfoundation.org> wrote: > > On Wed, Mar 25, 2015 at 09:53:34PM +0100, Marek Belisko wrote: > >> From: "H. Nikolaus Schaller" <h...@goldelico.com> > >> > >> While trying to test the Pyra GSM/GPS/3G module I had reconfigured > >> the USB interface by mistake and therefore needed to run a different > >> USB driver than CSC-ACM. It turned out that I need the "usbserial" driver. > >> > >> This file is an official description how to use it: > >> Documentation/usb/usb-serial.txt > >> > >> But it is outdated. The parameters vendor= and product= are no longer > >> available since ca. 3.12 which means that documentation is lagging behind > >> quite some time. > >> > >> Here was the solution: > >> > >> https://bbs.archlinux.org/viewtopic.php?id=175499 > >> > >> insmod usbserial vendor=0x#### product=0x#### > >> > >> becomes (first #### is vendor, second is product) > >> > >> modprobe usbserial > >> echo #### #### >/sys/bus/usb-serial/drivers/generic/new_id > >> > >> This patch changes the documentation file as needed. > >> > >> Signed-off-by: H. Nikolaus Schaller <h...@goldelico.com> > > > > You are forwarding on a patch from someone else, why didn't you also > > sign-off on it? Do you not agree with it? > I wasn't involved in patch development I just review it and forward.
If you reviewed and forwarded it, why did you not add a signed-off-by: to it? Do you not think it is acceptable for merging? If not, then we shouldn't either :) thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
