On Mon, 23 Mar 2015, Charles Keepax wrote:
> Some register settings must be applied before the first time low power
> sleep mode is entered on the wm5110 to ensure optimium performance.
> These settings require SYSCLK to be enabled whilst they are being
> applied. This patch applies the settings using the recently factored out
> boot time SYSCLK functionality.
>
> Signed-off-by: Charles Keepax <ckee...@opensource.wolfsonmicro.com>
> ---
> drivers/mfd/arizona-core.c | 42 ++++++++++++++++++++++++++++++++++++++++++
> 1 files changed, 42 insertions(+), 0 deletions(-)
No real problems with this:
Acked-by: Lee Jones <lee.jo...@linaro.org>
> diff --git a/drivers/mfd/arizona-core.c b/drivers/mfd/arizona-core.c
> index 695c68e..b82b909 100644
> --- a/drivers/mfd/arizona-core.c
> +++ b/drivers/mfd/arizona-core.c
> @@ -371,6 +371,38 @@ err:
> return err;
> }
>
> +/*
> + * Register patch to some of the CODECs internal write sequences
> + * to ensure a clean exit from the low power sleep state.
> + */
> +static const struct reg_default wm5110_sleep_patch[] = {
> + { 0x337A, 0xC100 },
> + { 0x337B, 0x0041 },
> + { 0x3300, 0xA210 },
> + { 0x3301, 0x050C },
> +};
> +
> +static inline int wm5110_apply_sleep_patch(struct arizona *arizona)
> +{
> + struct arizona_sysclk_state state;
> + int err, ret;
> +
> + ret = arizona_enable_freerun_sysclk(arizona, &state);
> + if (ret)
> + return ret;
> +
> + ret = regmap_multi_reg_write_bypassed(arizona->regmap,
> + wm5110_sleep_patch,
> + ARRAY_SIZE(wm5110_sleep_patch));
> +
> + err = arizona_disable_freerun_sysclk(arizona, &state);
> +
> + if (ret)
> + return ret;
> + else
> + return err;
> +}
> +
> #ifdef CONFIG_PM
> static int arizona_runtime_resume(struct device *dev)
> {
> @@ -940,6 +972,16 @@ int arizona_dev_init(struct arizona *arizona)
> goto err_reset;
> }
> break;
> + case WM5110:
> + case WM8280:
> + ret = wm5110_apply_sleep_patch(arizona);
> + if (ret) {
> + dev_err(arizona->dev,
> + "Failed to apply sleep patch: %d\n",
> + ret);
> + goto err_reset;
> + }
> + break;
> default:
> break;
> }
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
