On Tue, Mar 31, 2015 at 04:10:26PM +0200, Jiri Olsa wrote:
> On Mon, Mar 30, 2015 at 02:35:58PM -0600, David Ahern wrote:
> > 363b785f38 added synthesized fork events and set a thread's parent id
> > to itself. Since we are already processing /proc/<pid>/status the ppid
> > can be determined properly. Make it so.
> >
> > Signed-off-by: David Ahern <dsah...@gmail.com>
> > Cc: Don Zickus <dzic...@redhat.com>
> > Cc: Joe Mario <jma...@redhat.com>
> > Cc: Jiri Olsa <jo...@redhat.com>
> > ---
> > v3
> > - removed isspace and newline checks; added brackets per Arnaldo's comments
> >
> > v2:
> > - removed changes to function signature for perf_event__synthesize_comm as
> > noted by Jiri
> >
> > tools/perf/util/event.c | 83
> > +++++++++++++++++++++++++++++--------------------
> > 1 file changed, 50 insertions(+), 33 deletions(-)
> >
> > diff --git a/tools/perf/util/event.c b/tools/perf/util/event.c
> > index 023dd3548a94..5516236df6ab 100644
> > --- a/tools/perf/util/event.c
> > +++ b/tools/perf/util/event.c
> > @@ -51,29 +51,32 @@ static struct perf_sample synth_sample = {
> >
> > /*
> > * Assumes that the first 4095 bytes of /proc/pid/stat contains
> > - * the comm and tgid.
> > + * the comm, tgid and ppid.
> > */
> > -static pid_t perf_event__get_comm_tgid(pid_t pid, char *comm, size_t len)
> > +static int perf_event__get_comm_ids(pid_t pid, char *comm, size_t len,
> > + pid_t *tgid, pid_t *ppid)
> > {
> > char filename[PATH_MAX];
> > char bf[4096];
> > int fd;
> > size_t size = 0, n;
> > - pid_t tgid = -1;
> > - char *nl, *name, *tgids;
> > + char *nl, *name, *tgids, *ppids;
> > +
> > + *tgid = -1;
> > + *ppid = -1;
> >
> > snprintf(filename, sizeof(filename), "/proc/%d/status", pid);
> >
> > fd = open(filename, O_RDONLY);
> > if (fd < 0) {
> > pr_debug("couldn't open %s\n", filename);
> > - return 0;
> > + return -1;
>
> hum, missed this one in previous version.. why did not we fail before?
sigh, it was the tgid before, now it's err.. ;-) ook
jirka
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
