On 30/03/15 01:03, Bob Liu wrote: > > On 03/28/2015 08:44 AM, Konrad Rzeszutek Wilk wrote: >> On Thu, Mar 26, 2015 at 04:32:45PM +0100, Roger Pau Monné wrote: >>> El 26/03/15 a les 13.16, Bob Liu ha escrit: >>>> There are several place using gnttab async unmap and wait for >>>> completion, so move the common code to a function >>>> gnttab_unmap_refs_async_wait_completion(). >>>> >>>> Signed-off-by: Bob Liu <bob....@oracle.com> >>> >>> For the blkback parts: >>> >>> Acked-by: Roger Pau Monné <roger....@citrix.com> >>> >>> Although, as David already said, I think we should do better than BUG_ON >>> on error. >> > > This patch only keeps the existing behaviour the same as before. I > prefer to make new patches(based on this one) if want to change the > behaviour. > >> Have an 'stuck deferred pages' list and an timer to occasionally >> flush them out? Something similar to 569ca5b3f94cd0b3295ec5943aa457cf4a4f6a3a >> "xen/gnttab: add deferred freeing logic" ? > > Sounds like a good idea.
If it failed the first time I don't see how it would succeed later. No one has actually hit this particular BUG_ON() so I would leave it as is. David -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
