On Sat, Apr 04, 2015 at 08:10:09PM +0300, Pavel Nakonechny wrote:
> Hi Andrew
>
> ?? ???????????? ???? 4 ???????????? 2015 18:38:14 ????????????????????????
> Andrew Lunn ??????????????:
> > There is the code after applying your patch:
> >
> > static int dsa_of_setup_routing_table(struct dsa_platform_data *pd,
> > struct dsa_chip_data *cd,
> > int chip_index, int port_index,
> > struct device_node *link)
> > {
> > const __be32 *reg;
> > int link_sw_addr;
> > struct device_node *parent_sw;
> > int len;
> >
> > parent_sw = of_get_parent(link);
> > if (!parent_sw)
> > return -EINVAL;
> >
> > link is the phandle to the port in other switch. parent_sw is then the
> > switch property.
> yep
>
> > reg = of_get_property(parent_sw, "reg", &len);
> > if (!reg || (len != sizeof(*reg) * 2))
> > return -EINVAL;
> >
> > So now you get the reg property. This is documented as:
> >
> > - reg : Describes the switch address on the MII bus
> Yes, but read further in the entry example:
> "reg = <16 0>; /* MDIO address 16, switch 0 in tree */"
Ah!
O.K. Please add a comment. If i read this wrong, it is quite likely
somebody else will also read this wrong.
I think it would also be good to add some text to dsa.txt explaining
this second field in reg.
Andrew
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
