On 08/04/15 15:37, Irina Tirdea wrote: > Refactor code for simplicity and clarity. > > This also fixes an endianness issue with the original code. > When reading multiple registers, the received buffer of > 16-bytes words is little endian (status, step count). On > big endian machines, casting them to u32 would result in > reversed order in the buffer (step count, status) leading > to incorrect values for step count and activity. > > Signed-off-by: Irina Tirdea <[email protected]> > Suggested-by: Hartmut Knaack <[email protected]> Sensible fix, again fill pickup from reordered series. Thanks, > --- > drivers/iio/accel/mma9553.c | 11 ++++------- > 1 file changed, 4 insertions(+), 7 deletions(-) > > diff --git a/drivers/iio/accel/mma9553.c b/drivers/iio/accel/mma9553.c > index d781999..ee2be3f 100644 > --- a/drivers/iio/accel/mma9553.c > +++ b/drivers/iio/accel/mma9553.c > @@ -318,22 +318,19 @@ static int mma9553_set_config(struct mma9553_data > *data, u16 reg, > static int mma9553_read_activity_stepcnt(struct mma9553_data *data, > u8 *activity, u16 *stepcnt) > { > - u32 status_stepcnt; > - u16 status; > + u16 buf[2]; > int ret; > > ret = mma9551_read_status_words(data->client, MMA9551_APPID_PEDOMETER, > - MMA9553_REG_STATUS, sizeof(u32), > - (u16 *) &status_stepcnt); > + MMA9553_REG_STATUS, sizeof(u32), buf); > if (ret < 0) { > dev_err(&data->client->dev, > "error reading status and stepcnt\n"); > return ret; > } > > - status = status_stepcnt & MMA9553_MASK_CONF_WORD; > - *activity = mma9553_get_bits(status, MMA9553_MASK_STATUS_ACTIVITY); > - *stepcnt = status_stepcnt >> 16; > + *activity = mma9553_get_bits(buf[0], MMA9553_MASK_STATUS_ACTIVITY); > + *stepcnt = buf[1]; > > return 0; > } >
-- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
